Hi, I have made few minor changes in this patch to make it to work with Materialized View.
PFA patch with following changes: 1. Fixed typo issue for url parameter. 2. Check for 'hastoasttable' attribute in Disabled property of field "toast_autovaccum" in VacuumSettingsSchema. 3. Use Simplejson library instead of json. On Thu, Apr 7, 2016 at 4:19 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Rebase patch and sent again. > > > Regrds, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Apr 7, 2016 at 4:07 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> Please find updated patch, I have moved everything at schema level and >> tweak some code as well, so that we can use it in Table/View node. >> >> >> Regards, >> Murtuza >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Fri, Mar 25, 2016 at 4:50 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi Surinder, >>> >>> Can you please move all genereic logic & sql at schema level so that we >>> can use it in table node as well? >>> Currently it’s materialized view node centric only. >>> >>> >>> Regards, >>> Murtuza >>> >>> >>> On 23-Mar-2016, at 9:34 pm, Surinder Kumar < >>> surinder.ku...@enterprisedb.com> wrote: >>> >>> Hi, >>> >>> >>> On Fri, Mar 18, 2016 at 8:58 PM, Dave Page <dp...@pgadmin.org> wrote: >>> >>>> On Fri, Mar 18, 2016 at 10:37 AM, Surinder Kumar >>>> <surinder.ku...@enterprisedb.com> wrote: >>>> > Hi, >>>> > >>>> > PFA control for displaying auto vacuum fields into grid. This control >>>> is >>>> > common for >>>> > Materialized View Node and Table Node. >>>> > >>>> > Usage: >>>> > >>>> > { >>>> > id: 'vacuum_table', label: '{{ _("Vacuum Table") }}', >>>> > model: VacuumTableModel, editable: false, type: 'collection', >>>> > canEdit: true, group: '{{ _("Table") }}', >>>> > mode: ['edit', 'create'], url: 'get_vacuum_defaults', >>>> > control: Backform.VacuumCollectionControl.extend({ >>>> > grid_columns :[ >>>> > { >>>> > name: 'label', label: '{{ _("Label") }}', >>>> > cell: 'string', editable: false >>>> > }, >>>> > { >>>> > name: 'value', label: '{{ _("Value") }}', >>>> > cellFunction: cellFunction, editable: function(m) { >>>> > if(m.handler.has('autovacuum_enabled')) { >>>> > return m.handler.get('autovacuum_enabled'); >>>> > } >>>> > return !m.handler.isNew(); >>>> > } >>>> > }, >>>> > { >>>> > name: 'setting', label: '{{ _("Default value") }}', >>>> > cellFunction: cellFunction, editable: false >>>> > } >>>> > ] >>>> > }), >>>> > >>>> > >>>> > When using this control, provide following parameters in schema: >>>> > 1. model >>>> > 2. url - to fetch default values for auto vacuum fields. >>>> > 3. grid columns - Name of the columns to display in the grid. >>>> > >>>> > >>>> > Please review the patch. >>>> >>>> It's hard to review this without being able to test. Do you have a >>>> simple test case? >>>> >>> >>> I have submitted patch for materialized view which is using this >>> control. so you can test it in materialized view. >>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> >> >
Updated_VaccumSettings_Control_v2.patch
Description: Binary data
-- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
