Hi, PFA table add-on patch version 8.3. (apply after 8.2)
-- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, May 18, 2016 at 3:20 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA table add-on patch version 8.2 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, May 18, 2016 at 2:42 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch for table node (version 8.1). apply this patch on version 7 >> patch. Not all issue are fixed in this patch. Murtuza will be sending >> version 8.2 witch will have resolution for remaining issues. Apply version >> 8.2 patch on version 8.1 >> >> -- >> *Harshal Dhumal* >> *Software Engineer * >> >> >> >> EenterpriseDB <http://www.enterprisedb.com> >> >> On Tue, May 17, 2016 at 10:12 PM, Sanket Mehta < >> sanket.me...@enterprisedb.com> wrote: >> >>> Hi Harshal, >>> >>> >>> Below are my review comments: >>> >>> I got below warning when I tried to apply the patch for table node as >>> mentioned below: >>> >>> Table creation: >>> >>> - Trailing white spaces warnings >>> >>> $ git apply >>> /projects/patches/pgadmin4/Table/table_14_May_V6.patch >>> >>> /projects/patches/pgadmin4/Table/table_14_May_V6.patch:6008: trailing >>> whitespace. >>> return false; >>> >>> /projects/patches/pgadmin4/Table/table_14_May_V6.patch:6016: trailing >>> whitespace. >>> return false; >>> warning: 2 lines add whitespace errors. >>> >> >> Fixed (These were introduced due to rules node.) >> >> >>> >>> - In Table creation dialog, while adding a new primary key, it does >>> not allow to change the tablespace to empty. (which is not the case in >>> case >>> of tablespace in table) >>> >>> Fixed >> >>> >>> - In Table creation dialog, while adding a new column, data type and >>> name field must be mandatory. otherwise while clicking on save it gives >>> below error >>> >>> File >>> "/projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py", >>> line 1319, in _parse_format_columns >>> c['cltype'] = self._cltype_formatter(c['cltype']) >>> KeyError: 'cltype >>> >> Fixed >> >> >>> >>> - In Table creation dialog, While adding a new column, in primary >>> check box is needed to click twice in order to check it. Ideally it >>> should >>> be checked by only one click. >>> >>> This is Backgrid behaviour. >> >>> >>> - In Table creation dialog, While adding a new column, primary key >>> should not be allowed to added unless user has provided name and data >>> type >>> for at least one column. >>> >>> Fixed >> >>> >>> - currently if user has clicked on add column button and immediately >>> click on add primary key button, it will add a row in primary key data >>> grid >>> >>> Fixed >> >>> >>> - When delete table/drop cascade is apply on any table, i got a >>> javascript error as mentioned below >>> >>> node.js:94 Uncaught TypeError: self.canDrop.apply is >>> not a function >>> >> Already fixed in other commit. >> >> >>> >>> - Once the above error generated, every time user tries to open a >>> context menu by right clicking on any existing table, that same error >>> comes >>> >>> Already fixed in other commit. >> >>> >>> - In table creation dialog, if table is inherited from another >>> table, if a new primary key is added manually there, the create sql will >>> not have an entry for primary key >>> >>> Fixed >> >>> >>> - In table creation dialog, if primary key check box is checked >>> while adding the row, a new row is added in primary key datagrid but >>> unchecking the primary key checkbox from column datagrid, does not >>> removes >>> that row from primary key data grid. >>> >>> Fixed. >> >>> >>> - In AutoVacuum tab, if user provides any invalid value to any >>> parameter, then a error message should be prompted, only background color >>> change would not tell user to change the value. >>> >>> Expected behaviour. >> >>> >>> - In table creation dialog, security label are not being added. >>> javascript error is coming as mentioned below: >>> {"success": 0, "info": "", "result": null, "data": null, >>> "errormsg": "can't adapt type 'Undefined'"} >>> >>> Fixed >> >>> >>> - In Table creation dialog, while adding foreign key, in action tab. >>> if user click on 'x' button in "on update" or "on delete" select2 >>> control, >>> it gives error "Uncaught SyntaxError: Unexpected end of input" >>> >>> Fixed >> >>> >>> - In Table creation dialog, while adding a check constraint, >>> "validated" button does not work properly >>> >>> Fixed. >> >>> >>> - After successfully creation of table, "table name cannot be empty" >>> error is not getting cleared. >>> >>> Not reproducible. >> >>> >>> - In Table creation dialog, if user has added an empty column >>> without entering its name or type and trying to add check constraint, it >>> will add an empty constraint >>> >>> Expected behaviour (Columns are not mandatory for check constrains) >> >>> >>> - In Table creation dialog, while adding an exclude constraint, for >>> "character varying" column type, no operators are being listed >>> >>> There are no operators for character varying data type. >> >>> >>> - In Table creation dialog, while adding an exclude constraint, >>> below mentioned error comes if user removes operator class by clicking >>> 'x' >>> on that control Uncaught TypeError: Cannot read property 'id' of >>> undefined >>> >>> TODO >> >>> >>> - In Table creation dialog, SQL is not getting generated for exclude >>> constraint >>> >>> Fixed >> >>> >>> - In Table creation dialog, schema should be prefixed with table >>> name in "of type" control >>> >>> Fixed >> >>> >>> - In Table creation dialog, while adding privileges, it always shows >>> default privileges even if user has selected different privileges. (This >>> works fine once user edit the privileges in edit table mode and shows >>> only >>> those privileges which user selects). Ashesh, please confirm the >>> behaviour. >>> >>> Privileges are set correctly. Only it shows in incorrect order. >> >> >>> Table edit mode: >>> >>> - If in edit mode, any constraint is already having any comment, >>> then remove it. It will not create the SQL for the same. >>> >>> >> Fixed >> >>> >>> - Changing Schema will give server error >>> >>> This is generic issue for each node. >> >> >>> Column Creation: >>> >>> - Save button is enabled by default >>> - Data type validation is not provided. Save button is enabled just >>> after providing column name >>> - Length field limitation is not provided. (i.e. for numeric type, >>> length should be allowed greater than 1000) >>> >>> *Fixed* > >> Exclusion constraint creation: >>> >>> - Access method should not be allowed to be empty. (currently by >>> clicking 'x' will remove the selection in it) >>> >>> Access method is optional. >> >> >>> Index creation: >>> >>> - No error message for name field when empty >>> - No error message when column name is not provided while adding a >>> column in index >>> - While adding a column if no name is provided, "None" appears in >>> SQL tab which will give error on OK button click >>> - when comment is provided while creation, it gives error saying >>> index does not exists. because schema name is not added before it. >>> >>> *Fixed* > >> Rule creation: >>> >>> - Name is empty error does not come till user enters something in >>> definition tab >>> - DO INSTEAD button does not make any difference to SQL (it works in >>> edit mode) >>> >>> *Surinder will send patch* > >> Rule edit mode: >>> >>> - Add comment in edit mode, check the SQL in sql tab. Now come back >>> to general tab and removes comment and check the sql tab again. >>> SQL for comment is still there with empty string as comment >>> >>> *Surinder will send patch* > >> Trigger Creation: >>> >>> - SQL is not proper when creating a trigger. "()" should be appended >>> to function name in SQL. >>> It gives error while creating a trigger >>> - "+" sign is visible in browser tree in front of trigger. either >>> On expanding trigger, it should show the trigger function name or that >>> "+" >>> sign should not appear >>> >>> *Fixed* > >> Trigger edit node: >>> >> >>> - On removing comment, nothing happens. No sql is being created. >>> Comment is still there in properties. >>> >>> *Fixed* > >> >>> Regards, >>> Sanket Mehta >>> Sr Software engineer >>> Enterprisedb >>> >> >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> >
table_v8.3.patch
Description: Binary data
-- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
