On 24 May 2016 at 19:09, Ashesh Vashi <ashesh.va...@enterprisedb.com> wrote:
> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch, which will fixes below mentioned issues,
>>
> Committed.
>
In the Create Table dialog, on the Advanced tab, the "Of type" drop-down
lists tables and composite types, but those are supposed to just be
composite types.
Also, when using OF in CREATE TABLE, LIKE is no longer valid, so LIKE
should be disabled when using OF. Also, there should probably be a way of
setting options for the columns taken from the composite type. For example:
CREATE TYPE inventory AS (product_id bigint, product_name text, weight
numeric);
CREATE TABLE stock OF inventory (
PRIMARY KEY (product_id),
weight WITH OPTIONS DEFAULT 0
);
There's currently no way of doing this (neither the primary key, nor the
default value for any columns). It should probably automatically populate
the columns from the composite type on the columns tab.
Also, could the generated SQL have an empty line between each statement?
Thanks
Thom
