Thanks - committed with a lot more improvements. Along with changes for the security labels, now - using the common backbone model for it for each of the node, instead of defining them in each of the node modules.
-- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Fri, May 27, 2016 at 2:38 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > PFA patch with following fixes: > 1. Introduced a new function *'is_security_group_under_catalog' *which > return false if node of *type: group* is under > catalog otherwise true. > 2. In security group, group-id is simple string. > 3. Fixed indentation in schema.js. > 4. Also set *parent_type* of sequence node to *catalogs *which i missed > in previous patch. > > Please review the patch. > > On Thu, May 26, 2016 at 8:57 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> On Wed, May 25, 2016 at 7:44 PM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Hi >>> >>> Following are the issues fixed in this patch: >>> 1. Nodes not expanding under catalogs >>> *Issue: *Check for setting schema was missing. schema should set only >>> if node is in create mode. >>> >>> 2. Error fetching node's properties. >>> *Issue: *Node attribute *parent_type* is not set to catalogs. >>> >>> 3. Don't show create rule option in table create menu if it is under >>> catalog. >>> >>> 4. Security tab of node should be hidden under catalogs. >>> Every node with controls *privilege and security labels* must be under >>> *type: >>> group* >>> to keep them hide when node is listed under catalogs. >>> This code is implemented in backform.pgadmin.js >>> >>> *For Example:* >>> >>> *schema:[*{ >>> id: '*security*', label: '{{ _("Security") }}', >>> *type: 'group'* >>> },{ >>> id: 'acl', label: '{{ _('Privileges') }}', *group: '{{ _('security') >>> }}'* >>> >> This is wrong - you should not put the group-id as i18n string. >> It should be a simple string. i.e. group: 'security' >> >>> },{ >>> id: 'seclabels', label: '{{ _('Security Labels') }}', >>> model: SecurityModel, type: 'collection', >>> *group: '{{ _('security') }}'* >>> >> Same as above. >> >>> }*]* >>> >>> Please find attached patch and review. >>> >> I also found - we're not consistent about showing ACL on all the node. >> For some node, we're not showing ACLs in properties mode. >> >> Please send patch with above fixes. >> > >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> <http://www.enterprisedb.com/> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> <http://www.linkedin.com/in/asheshvashi> >> >>> >>> >>> Thanks, >>> Surinder Kumar >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > >
