Hmm - that was clearly hiding from me. I'll take a look now. Did you see the rest of my comments?
On Thu, Sep 22, 2016 at 3:37 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com> wrote: > I sent an updated patch immediately. > > > On Sep 22, 2016 20:01, "Dave Page" <dp...@pgadmin.org> wrote: >> >> Hi >> >> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi >> <ashesh.va...@enterprisedb.com> wrote: >>> >>> Hi Dave, >>> >>> Please find the patch for support for paAgent in pgAdmin 4. >> >> >> Did you forget the binary switch? >> >> piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch >> error: cannot apply binary patch to >> 'web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/coll-pga_schedule.png' >> without full index line >> error: >> web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/coll-pga_schedule.png: >> patch does not apply >> error: cannot apply binary patch to >> 'web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/pga_schedule.png' >> without full index line >> error: >> web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/pga_schedule.png: >> patch does not apply >> error: cannot apply binary patch to >> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/img/coll-pga_job.png' >> without full index line >> error: >> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/coll-pga_job.png: >> patch does not apply >> error: cannot apply binary patch to >> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job-disabled.png' >> without full index line >> error: >> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job-disabled.png: >> patch does not apply >> error: cannot apply binary patch to >> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job.png' >> without full index line >> error: >> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job.png: >> patch does not apply >> error: cannot apply binary patch to >> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/coll-pga_jobstep.png' >> without full index line >> error: >> web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/coll-pga_jobstep.png: >> patch does not apply >> error: cannot apply binary patch to >> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/pga_jobstep.png' >> without full index line >> error: >> web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/pga_jobstep.png: >> patch does not apply >>> >>> >>> I have also attached another patch for miscellaneous fixes, and adding >>> new controls. >>> It includes: >>> - Added DatetimepickerControl, MomentCell (using moment.js) >>> - Used the 'DatetimepickerControl' in Role (Also - resolved an issue, >>> when unset the datetime for 'Valid Until'.) >>> - Added a 'Select All/Unselect All' adaptor for Select2 used by pgAgent >>> nodes. >>> - Fixed an issue with SubNodeCollectionControl, which was not starting >>> the modification session of the child model, when created default value for >>> collection is not null/undefined. And, hence - validation on the child model >>> was not working. >>> - Fixed a memory leak with SqlFieldControl, and SqlTabControl, which was >>> not releasing the CodeMirror properly. >> >> >> Urgh, that's big. Applied - but can you look at the following please? >> >> - Account expires has a hint of 'MMM D YYYY HH:mm:ss.SSS Z". Are >> milliseconds really needed? I also get 00 as a fractional timezone offset. >> Perhaps we should hide that, when it's 00? >> >> - The date format differs from the ISO format displayed by the query tool. >> They should be consistent - and really should be either based on the >> client's locale settings, or ISO format. >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
