[pgadmin-hackers] [pgAdmin4][Patch]: RM 1780: Rendering glitches in the query editor line number column when editing many lines

[Khushboo Vashi]

Hi,

Please find the attached patch to fix the RM 1780: Rendering glitches in
the query editor line number column when editing many lines.

Some codemirror css were overwritten to increase the width of the line
number column in sql editor.
Due to those changes this issue was coming, I have removed those css
changes and set the line number column to the default size.

Please review the patch and let me know if any other UI changes are
required.

Thanks,
Khushboo

diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css
index ad84aa7..01681de 100755
--- a/web/pgadmin/static/css/overrides.css
+++ b/web/pgadmin/static/css/overrides.css
@@ -51,11 +51,6 @@ iframe {
     border-width: 0;
 }
 
-/* Ensure the codemirror editor displays full height gutters when resized */
-.CodeMirror, .CodeMirror-gutters {
-    height: 100% !important;
-}
-
 /* Padding for the treeview */
 .browser-browser-pane {
     padding-left: 0;
diff --git a/web/pgadmin/tools/sqleditor/static/css/sqleditor.css b/web/pgadmin/tools/sqleditor/static/css/sqleditor.css
index f22963b..35c18ef 100644
--- a/web/pgadmin/tools/sqleditor/static/css/sqleditor.css
+++ b/web/pgadmin/tools/sqleditor/static/css/sqleditor.css
@@ -157,24 +157,13 @@
 
 .CodeMirror, #editor-panel .CodeMirror-gutters {
     min-height: 100%;
+    height: 100%;
 }
 
-/* Changes specific to output panel of query tool */
-#output-panel, #output-panel .CodeMirror, #output-panel .CodeMirror-gutters {
+#output-panel {
   height: 100% !important;
 }
 
-#output-panel .CodeMirror-gutter-wrapper {
-  width: 43px;
-  height: 22px;
-  border-right: 1px solid #ddd !important;
-  background: #f7f7f7 !important;
-}
-
-.CodeMirror-foldgutter {
-  width: .9em;
-}
-
 .CodeMirror-foldgutter-open,
 .CodeMirror-foldgutter-folded {
   cursor: pointer;
@@ -431,8 +420,8 @@ input.editor-checkbox {
   Ref: https://github.com/mleibman/SlickGrid/issues/742
 */
 .slickgrid, .slickgrid *, .slick-header-column {
-        box-sizing: content-box;
-        -moz-box-sizing: content-box;
-        -webkit-box-sizing: content-box;
-        -ms-box-sizing: content-box;
-}
\ No newline at end of file
+  box-sizing: content-box;
+  -moz-box-sizing: content-box;
+  -webkit-box-sizing: content-box;
+  -ms-box-sizing: content-box;
+}

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers