Thanks - I committed this, though I changed with spacing to 1em as 0.7 wasn't quite enough on my machine.
On Mon, Dec 19, 2016 at 6:24 AM, Khushboo Vashi <khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached patch to fox the block folding issue in the editor. > > Thanks, > Khushboo > > On Fri, Dec 16, 2016 at 10:35 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi Khushboo >> >> I just noticed this broke block folding in the editor, as it doesn't >> leave enough room in the gutter for the arrows. See the attached >> screenshots from the query tool (note that the mis-placed arrows >> cannot be toggled). >> > Fixed > >> Can you fix this ASAP please? I haven't reverted your patch. >> >> Please also check the block folding and breakpoint display in the >> debugger. >> > This is working fine as I haven't touch the debugger css. Most of the > changes are done in the editor's css. > I have set the min width of the gutter to 0.7em in editor, whereas in the > debugger the width is 0.9em because of breakpoint. > > So, please review the patch and let me know if any changes are required. > >> >> Thanks. >> >> On Fri, Dec 16, 2016 at 1:04 PM, Dave Page <dp...@pgadmin.org> wrote: >> > Thanks, patch applied! >> > >> > On Fri, Dec 16, 2016 at 9:12 AM, Khushboo Vashi >> > <khushboo.va...@enterprisedb.com> wrote: >> >> Hi, >> >> >> >> Please find the attached updated patch. >> >> >> >> Thanks, >> >> Khushboo >> >> >> >> On Mon, Dec 12, 2016 at 3:30 PM, Dave Page <dp...@pgadmin.org> wrote: >> >>> >> >>> Hi >> >>> >> >>> On Fri, Dec 9, 2016 at 11:37 AM, Khushboo Vashi >> >>> <khushboo.va...@enterprisedb.com> wrote: >> >>> > Hi, >> >>> > >> >>> > Please find the attached patch to fix the RM 1780: Rendering >> >>> > glitches in >> >>> > the >> >>> > query editor line number column when editing many lines. >> >>> > >> >>> > Some codemirror css were overwritten to increase the width of the >> >>> > line >> >>> > number column in sql editor. >> >>> > Due to those changes this issue was coming, I have removed those css >> >>> > changes >> >>> > and set the line number column to the default size. >> >>> > >> >>> > Please review the patch and let me know if any other UI changes are >> >>> > required. >> >>> >> >>> This seems to work nicely in the query tool, as well as the properties >> >>> pane and for the source code on the properties dialogues for >> >>> functions/views etc. >> >>> >> >>> However, it doesn't seem to work well on the SQL tab of dialogues (see >> >>> the attached screenshot). If you can fix that without changing the >> >>> now-improved behaviour elsewhere, I think this will be a good >> >>> improvement. >> >> >> >> >> >> Fixed >> >> >> >>> >> >>> Thanks. >> >>> >> >>> -- >> >>> Dave Page >> >>> Blog: http://pgsnake.blogspot.com >> >>> Twitter: @pgsnake >> >>> >> >>> EnterpriseDB UK: http://www.enterprisedb.com >> >>> The Enterprise PostgreSQL Company >> >> >> >> >> > >> > >> > >> > -- >> > Dave Page >> > Blog: http://pgsnake.blogspot.com >> > Twitter: @pgsnake >> > >> > EnterpriseDB UK: http://www.enterprisedb.com >> > The Enterprise PostgreSQL Company >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
