Hi Ashesh and Rainer,

Le vendredi 17 juillet 2009 à 13:30:43, Ashesh Vashi a écrit :
> [Adding pgadmin-hackers..]
>
> Hi Rainer,
>
> I am able to reproduce the same on Ubuntu 9.04 (32 bit).
> Thanks for reporting this.
>
> Hi Dave/Guillaume,
>
> Please find the patch for the same.
> Schedule dialog does not have SQL pane.
> And, we're try to check the Read-Only check-box over there. :(
>

Yeah, you found the issue. There was another one on the dlgStep dialog. Only 
dlgJob need this. I changed your patch to fix the two issues. You'll find it 
attached for reference. I've commited this patch on the 1.10 branch and on the 
trunk.

Thanks a lot.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com
Index: dlgStep.cpp
===================================================================
--- dlgStep.cpp	(révision 7971)
+++ dlgStep.cpp	(copie de travail)
@@ -84,8 +84,6 @@
 
 int dlgStep::Go(bool modal)
 {
-	int returncode;
-	
     hasConnStrSupport = connection->TableHasColumn(wxT("pgagent"), wxT("pga_jobstep"), wxT("jstconnstr"));
     cbDatabase->Append(wxT(" "));
     cbDatabase->SetSelection(0);
@@ -141,11 +139,7 @@
             rbLocalConn->Enable(false);
     }
 
-    returncode = dlgProperty::Go(modal);
-	
-	SetSqlReadOnly(true);
-
-	return returncode;
+	return dlgProperty::Go(modal);
 }
 
 
Index: dlgSchedule.cpp
===================================================================
--- dlgSchedule.cpp	(révision 7971)
+++ dlgSchedule.cpp	(copie de travail)
@@ -114,8 +114,6 @@
 
 int dlgSchedule::Go(bool modal)
 {
-	int returncode;
-
     if (schedule)
     {
         // edit mode
@@ -198,11 +196,7 @@
         // create mode
     }
 
-    returncode = dlgProperty::Go(modal);
-	
-	SetSqlReadOnly(true);
-
-	return returncode;
+	return dlgProperty::Go(modal);
 }
 
 
-- 
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support

Reply via email to