Le dimanche 19 juillet 2009 à 23:42:50, Guillaume Lelarge a écrit :
> Hi Ashesh and Rainer,
>
> Le vendredi 17 juillet 2009 à 13:30:43, Ashesh Vashi a écrit :
> > [Adding pgadmin-hackers..]
> >
> > Hi Rainer,
> >
> > I am able to reproduce the same on Ubuntu 9.04 (32 bit).
> > Thanks for reporting this.
> >
> > Hi Dave/Guillaume,
> >
> > Please find the patch for the same.
> > Schedule dialog does not have SQL pane.
> > And, we're try to check the Read-Only check-box over there. :(
>
> Yeah, you found the issue. There was another one on the dlgStep dialog.
> Only dlgJob need this. I changed your patch to fix the two issues. You'll
> find it attached for reference. I've commited this patch on the 1.10 branch
> and on the trunk.
>
Hmmm. I should better think before applying a patch. The previous one does not
fix every issues. dlgStep can be displayed alone (in which case it does have a
SQL pane) and from the dlgJob dialog (in which case it doesn't). The same for
dlgSchedule. This new patch takes care of this.
Sorry about all this.
--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com
Index: pgadmin/agent/dlgStep.cpp
===================================================================
--- pgadmin/agent/dlgStep.cpp (révision 7976)
+++ pgadmin/agent/dlgStep.cpp (copie de travail)
@@ -84,6 +84,8 @@
int dlgStep::Go(bool modal)
{
+ int returncode;
+
hasConnStrSupport = connection->TableHasColumn(wxT("pgagent"), wxT("pga_jobstep"), wxT("jstconnstr"));
cbDatabase->Append(wxT(" "));
cbDatabase->SetSelection(0);
@@ -139,7 +141,14 @@
rbLocalConn->Enable(false);
}
- return dlgProperty::Go(modal);
+ returncode = dlgProperty::Go(modal);
+
+ if (nbNotebook->GetPageCount() == 3)
+ {
+ SetSqlReadOnly(true);
+ }
+
+ return returncode;
}
Index: pgadmin/agent/dlgSchedule.cpp
===================================================================
--- pgadmin/agent/dlgSchedule.cpp (révision 7976)
+++ pgadmin/agent/dlgSchedule.cpp (copie de travail)
@@ -114,6 +114,8 @@
int dlgSchedule::Go(bool modal)
{
+ int returncode;
+
if (schedule)
{
// edit mode
@@ -196,7 +198,14 @@
// create mode
}
- return dlgProperty::Go(modal);
+ returncode = dlgProperty::Go(modal);
+
+ if (nbNotebook->GetPageCount() == 5)
+ {
+ SetSqlReadOnly(true);
+ }
+
+ return returncode;
}
--
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support
