On Wed, Dec 2, 2015 at 3:08 PM, Per Wigren <[email protected]> wrote:
> No, they have just started the process of merging upstream, starting with
> the same version they forked from, then merging forward a few commits at at
> time. That is a huge undertaking so I suspect that it will take quite a
> while before there is a stable release based on modern PostgreSQL.
>
> I would very much like to have the warning dialog removed before the next
> pgAdmin3 release. Everything I have tried works as good as with PostgreSQL
> 9.4:
> * Connecting
> * Running queries
> * Viewing Greenplum specific explain plans
> * Table definitions show Greenplum specific syntax like DISTRIBUTED BY
> * Editing functions, views and rules work
> * Other Greenplum specific things like viewing Resource Queues and External
> Tables (similar to foreign tables) work properly
> * Table properties/statistics/dependencies/dependents work
> * Creating/dropping/modifying users/roles work
> * Server status works
>
> // Per
Are you able to test the attached patch?
> tis 1 dec. 2015 kl 13:09 skrev Dave Page <[email protected]>:
>>
>> On Fri, Nov 27, 2015 at 10:57 AM, Per Wigren <[email protected]> wrote:
>> > 2015-11-27 10:02 GMT+01:00 Dave Page <[email protected]>:
>> >>
>> >>
>> >> What version does GP report itself as if you do "SELECT version()"?
>> >>
>> >
>> > PostgreSQL 8.2.15 (Greenplum Database 4.3.6.1 build 2) on
>> > x86_64-unknown-linux-gnu, compiled by GCC gcc (GCC) 4.4.2 compiled on
>> > Oct 1
>> > 2015 15:14:22
>> >
>> > It was originally forked from PostgreSQL 8.2.15 but they have backported
>> > and/or developed many of the features of newer versions in parallel (no
>> > pun
>> > intended), including protocol and system table changes used by modern
>> > drivers and client tools like pgAdmin.
>>
>> I thought the code they were releasing was supposed to be based on a
>> newer version?
>>
>> In any case, in principal I don't object to fixing the message to not
>> be shown on GP, however we really need someone to test it properly
>> first to be sure that there are no problems. At one point that was
>> done by Greenplum, but not at present (as far as I know).
>> Unfortunately that's not something I or my team at EDB can do.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/pgadmin/include/pgAdmin3.h b/pgadmin/include/pgAdmin3.h
index 2a56d0f..9259070 100644
--- a/pgadmin/include/pgAdmin3.h
+++ b/pgadmin/include/pgAdmin3.h
@@ -60,6 +60,10 @@ const short SERVER_MIN_VERSION_N = 0x0804;
const wxString SERVER_MIN_VERSION_T = wxT("8.4");
const short SERVER_MAX_VERSION_N = 0x0905;
const wxString SERVER_MAX_VERSION_T = wxT("9.5");
+const short GP_SERVER_VERSION_N = 0x0802;
+const wxString GP_SERVER_VERSION_T = wxT("8.2");
+const short GP_SERVER_MAX_VERSION_N = 0x0802;
+const wxString GP_SERVER_MAX_VERSION_T = wxT("8.2");
// The registry file
#ifndef __WXMSW__
diff --git a/pgadmin/schema/pgServer.cpp b/pgadmin/schema/pgServer.cpp
index d60920d..9be09d0 100644
--- a/pgadmin/schema/pgServer.cpp
+++ b/pgadmin/schema/pgServer.cpp
@@ -835,14 +835,29 @@ int pgServer::Connect(frmMain *form, bool askPassword,
const wxString &pwd, bool
dbOid = conn->GetDbOid();
// Check the server version
- if (!(conn->BackendMinimumVersion(SERVER_MIN_VERSION_N >> 8,
SERVER_MIN_VERSION_N & 0x00FF)) ||
- (conn->BackendMinimumVersion(SERVER_MAX_VERSION_N >> 8,
(SERVER_MAX_VERSION_N & 0x00FF) + 1)))
+ if (conn->GetIsGreenplum())
{
- wxLogWarning(_("The server you are connecting to is not
a version that is supported by this release of %s.\n\n%s may not function as
expected.\n\nSupported server versions are %s to %s."),
-
appearanceFactory->GetLongAppName().c_str(),
-
appearanceFactory->GetLongAppName().c_str(),
- wxString(SERVER_MIN_VERSION_T).c_str(),
- wxString(SERVER_MAX_VERSION_T).c_str());
+ if
(!(conn->BackendMinimumVersion(GP_SERVER_MIN_VERSION_N >> 8,
GP_SERVER_MIN_VERSION_N & 0x00FF)) ||
+
(conn->BackendMinimumVersion(GP_SERVER_MAX_VERSION_N >> 8,
(GP_SERVER_MAX_VERSION_N & 0x00FF) + 1)))
+ {
+ wxLogWarning(_("The Greenplum server you are
connecting to is not a version that is supported by this release of %s.\n\n%s
may not function as expected.\n\nSupported server versions are %s to %s."),
+
appearanceFactory->GetLongAppName().c_str(),
+
appearanceFactory->GetLongAppName().c_str(),
+
wxString(GP_SERVER_MIN_VERSION_T).c_str(),
+
wxString(GP_SERVER_MAX_VERSION_T).c_str());
+ }
+ }
+ else
+ {
+ if (!(conn->BackendMinimumVersion(SERVER_MIN_VERSION_N
>> 8, SERVER_MIN_VERSION_N & 0x00FF)) ||
+
(conn->BackendMinimumVersion(SERVER_MAX_VERSION_N >> 8, (SERVER_MAX_VERSION_N &
0x00FF) + 1)))
+ {
+ wxLogWarning(_("The server you are connecting
to is not a version that is supported by this release of %s.\n\n%s may not
function as expected.\n\nSupported server versions are %s to %s."),
+
appearanceFactory->GetLongAppName().c_str(),
+
appearanceFactory->GetLongAppName().c_str(),
+ wxString(SERVER_MIN_VERSION_T).c_str(),
+ wxString(SERVER_MAX_VERSION_T).c_str());
+ }
}
connected = true;
--
Sent via pgadmin-support mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support
