On 2019-11-06 10:49, Fujii Masao wrote:
On Wed, Nov 6, 2019 at 4:29 PM Peter Eisentraut
<peter.eisentr...@2ndquadrant.com> wrote:

On 2019-11-06 05:48, Fujii Masao wrote:
Patch attached. As I argued upthread, IMO it's better to remove
the latter description from the doc and the patch does that.
Also the patch adds "mainly" into the former description.

I think we should list explicitly what is applied and what is not.  This
is the reference documentation after all.

That's possible, but may make the document more complicated and confusing,
I'm afraid. Because the parameters used for archive recovery and standby mode
are not categorized cleanly.

After reading this again and again, I think the best fix to get PG12 into "correct" shape is to just remove the offending sentence:

diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 46bc31de4c..fdebe9bf4b 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -3217,9 +3217,7 @@ <title>Archive Recovery</title>
takes precedence. Targeted recovery mode ends when the archived WAL is fully replayed, or when <varname>recovery_target</varname> is reached.
      In this mode, the parameters from both this section and <xref
- linkend="runtime-config-wal-recovery-target"/> will be used. Parameters
-     from <xref linkend="runtime-config-replication-standby"/> will not be
-     used.
+     linkend="runtime-config-wal-recovery-target"/> will be used.
     </para>

     <variablelist>


As we are discussing in other threads, there is further opportunity to reorganize how these settings interact, but that's a different project.

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Reply via email to