On 4/17/20 3:27 PM, Daniel Gustafsson wrote: >> On 17 Apr 2020, at 20:19, Andrew Dunstan <[email protected]> wrote: >> >> Only provide new libpq sslpasskey hook for openssl-enabled builds >> >> In commit 4dc6355210 I neglected to put #ifdef USE_OPENSSL around the >> declarations of the new items. This is remedied here. > This wasn't really the problem I reported though. As per my patch [0] in the > email, the issue is with openssl_tls_init_hook in src/include/libpq/libpq-be.h > requiring an OpenSSL specific SSL_CTX parameter, thus breaking compilation for > other TLS backends. The name also makes it somewhat backend specific =) > > PQgetSSLKeyPassHook is written generic enough that it could make sense for > other backends too, but for now I think we can keep the guards introduced in > this commit. > > cheers ./daniel >
Oh, *sigh* brainfade. Will fix. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
