> On 17 Apr 2020, at 21:46, Andrew Dunstan <[email protected]> > wrote: > > On 4/17/20 3:27 PM, Daniel Gustafsson wrote: >>> On 17 Apr 2020, at 20:19, Andrew Dunstan <[email protected]> wrote: >>> >>> Only provide new libpq sslpasskey hook for openssl-enabled builds >>> >>> In commit 4dc6355210 I neglected to put #ifdef USE_OPENSSL around the >>> declarations of the new items. This is remedied here. >> This wasn't really the problem I reported though. As per my patch [0] in the >> email, the issue is with openssl_tls_init_hook in >> src/include/libpq/libpq-be.h >> requiring an OpenSSL specific SSL_CTX parameter, thus breaking compilation >> for >> other TLS backends. The name also makes it somewhat backend specific =) >> >> PQgetSSLKeyPassHook is written generic enough that it could make sense for >> other backends too, but for now I think we can keep the guards introduced in >> this commit. > > Oh, *sigh* brainfade. > > Will fix.
Thanks, f342d7ad03e61a1cea0339cf0c5aea0d01c3b43e was more what I had in mind. cheers ./daniel
