On Wed, Mar 10, 2021 at 10:57 PM Michael Paquier <[email protected]> wrote: > I think that this commit has some issues that need more thoughts. > > The removal of vacuum_cleanup_index_scale_factor means that any > existing deployment of Postgres that includes at least one index using > this parameter would fail in the middle of the restore during > pg_upgrade, when restoring the binary dump.
I don't believe that it's necessary. Partly because it seems rather unlikely that vacuum_cleanup_index_scale_factor was ever set like this in practice. You could have made the same arguments against removing recheck_on_update in commit 1c53c4de. -- Peter Geoghegan
