On Mon, Apr 05, 2021 at 10:57:22AM -0400, Tom Lane wrote: > Some of the buildfarm seems not to like this. gaur failed here:
Thanks. I did not notice these. > I didn't look at the code, but I bet this is similar to the race > conditions we've seen before where a server process may exit before > the perl test script finishes stuffing a command down the pipe. Hmm. Those failures refer to the 5th and 8th tests of 001_password.pl where connect_ok() is used. The only logical differences compared to the previous code are: - The addition of on_error_stop in connect_ok() to ignore any errors - The fact that this now defines a SQL query (was undef previously). - $Test::Builder::Level So, the problem is with on_error_stop. That's not necessary anyway, but I am a bit surprised that this would be an issue. I'll apply that to see if it fixes the issue. If it does not, a revert would be better at this stage. -- Michael
diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm index bbde34c929..95e107373b 100644 --- a/src/test/perl/PostgresNode.pm +++ b/src/test/perl/PostgresNode.pm @@ -1901,8 +1901,7 @@ sub connect_ok 'postgres', $sql, extra_params => ['-w'], - connstr => "$connstr", - on_error_stop => 0); + connstr => "$connstr"); is($ret, 0, $test_name);
signature.asc
Description: PGP signature
