On Wed, Jan 12, 2022 at 8:36 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > 1. It lacks the usual anti-multiple-inclusion guard, i.e. > #ifndef WIN32NTDLL_H > or the like. Was there a specific reason to omit that?
Oops. Fixed. > 2. headerscheck and cpluspluscheck don't like it, at least > not on non-Windows: > > $ src/tools/pginclude/headerscheck > In file included from /tmp/headerscheck.WKh8cz/test.c:2: > ./src/include/port/win32ntdll.h:20:10: fatal error: ntstatus.h: No such file > or directory > #include <ntstatus.h> > ^~~~~~~~~~~~ > > One way to solve that, perhaps, is to wrap the whole header > in #ifdef WIN32. But I think our more usual practice has > been to add such headers to the exclusion lists in those > two scripts. Done. Those scripts aren't really on my radar... would it be a good idea to run them as steps in the CompilerWarnings CI task?
