On 1/11/22 16:22, Thomas Munro wrote: > 2. headerscheck and cpluspluscheck don't like it, at least >> not on non-Windows: >> >> $ src/tools/pginclude/headerscheck >> In file included from /tmp/headerscheck.WKh8cz/test.c:2: >> ./src/include/port/win32ntdll.h:20:10: fatal error: ntstatus.h: No such file >> or directory >> #include <ntstatus.h> >> ^~~~~~~~~~~~ >> >> One way to solve that, perhaps, is to wrap the whole header >> in #ifdef WIN32. But I think our more usual practice has >> been to add such headers to the exclusion lists in those >> two scripts. > Done. > > Those scripts aren't really on my radar... would it be a good idea to > run them as steps in the CompilerWarnings CI task? > >
Or in a buildfarm module (c.f. the perl checks) cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
