Hi, On 2022-07-18 19:56:18 +0000, Andres Freund wrote: > ecpg: Output dir, source dir, stamp file argument for preproc/*.pl > > This is in preparation for building postgres with meson / ninja. > > When building with meson, commands are run at the root of the build tree. Add > an option to put build output into the appropriate place. This can be utilized > by src/tools/msvc/ for a minor simplification, which also provides some > coverage for the new option. > > Add option to generate a timestamp for check_rules.pl, so that proper > dependencies on it having been run can be generated.
> Reviewed-by: Peter Eisentraut <[email protected]> > Discussion: > https://postgr.es/m/[email protected] Crake is relaying a perlcritic error: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-07-18%2020%3A36%3A30 Jul 18 16:48:25 ./src/interfaces/ecpg/preproc/parse.pl: Bareword file handle opened at line 30, column 1. See pages 202,204 of PBP. ([InputOutput::ProhibitBarewordFileHandles] Severity: 5) Jul 18 16:48:25 ./src/interfaces/ecpg/preproc/parse.pl: Bareword file handle opened at line 31, column 1. See pages 202,204 of PBP. ([InputOutput::ProhibitBarewordFileHandles] Severity: 5) afaict that's bogus. It's unnecessary that the code uses "our" instead of "my", but there's no bareword there and replacing our with my fixes that complaint. Am I misunderstanding something here? Greetings, Andres Freund
