Andres Freund <[email protected]> writes:
> On 2022-07-18 18:06:22 -0400, Tom Lane wrote:
>> I took it out and fixed the half-dozen places where I got warnings,
>> as attached.
> Grepping for 'no warnings' shows that check_rules.pl has the same
> issue. Perhaps worth fixing at the same time, given how closely related they
> are?
Ah, I didn't think to look around. I'll see what I can do there.
>> Seem like a good fix?
> Looks good to my not-perl-trained eyes.
Yeah, I'm more worried about non-idiomatic usage than whether
it works or not.
> Might be worth making sure the output files are the same before / after? You
> probably already checked...
Yup, I did.
regards, tom lane
