On Mon, Aug 18, 2025 at 09:47:14AM -0400, Tom Lane wrote:
> Michael Paquier <mich...@paquier.xyz> writes:
> > Move SQL-callable code related to multixacts into its own file
> 
> Couldn't this have removed some #include-s from multixact.c?

Right.  funcapi.h and fmgrprotos.h are direct dependencies, but
looking closer it is also possible to remove four more of them.
--
Michael
diff --git a/src/backend/access/transam/multixact.c b/src/backend/access/transam/multixact.c
index 886740d2d553..6a7963ccd03f 100644
--- a/src/backend/access/transam/multixact.c
+++ b/src/backend/access/transam/multixact.c
@@ -70,16 +70,12 @@
 
 #include "access/multixact.h"
 #include "access/slru.h"
-#include "access/transam.h"
 #include "access/twophase.h"
 #include "access/twophase_rmgr.h"
-#include "access/xact.h"
 #include "access/xlog.h"
 #include "access/xloginsert.h"
 #include "access/xlogutils.h"
 #include "commands/dbcommands.h"
-#include "funcapi.h"
-#include "lib/ilist.h"
 #include "miscadmin.h"
 #include "pg_trace.h"
 #include "pgstat.h"
@@ -87,7 +83,6 @@
 #include "storage/pmsignal.h"
 #include "storage/proc.h"
 #include "storage/procarray.h"
-#include "utils/fmgrprotos.h"
 #include "utils/guc_hooks.h"
 #include "utils/injection_point.h"
 #include "utils/memutils.h"

Attachment: signature.asc
Description: PGP signature

Reply via email to