Hi, On 2025-08-19 14:01:52 +0000, Bertrand Drouvot wrote: > On Tue, Aug 19, 2025 at 12:31:14PM +0200, Álvaro Herrera wrote: > > After these two changes, a lot of > > files can stop including dbcommands.h. This seems a nice cleanup to me, > > and passes headerscheck. > > meson does report: > > ../src/test/modules/worker_spi/worker_spi.c: In function ‘worker_spi_launch’: > ../src/test/modules/worker_spi/worker_spi.c:455:25: error: implicit > declaration of function ‘get_database_oid’ [-Wimplicit-function-declaration] > 455 | dboid = get_database_oid(worker_spi_database, false); > > It looks like pg_database.h include is missing in worker_spi.c. > > That said, autoconf does not report the issue, and that's because test/modules > is missing in src/Makefile. Is there any reasons for that? If not, the > attached > fix it.
That can't be the reason - it's reached from src/test/Makefile > SUBDIRS = perl postmaster regress isolation modules authentication recovery > subscription Greetings, Andres Freund
