On Tue, Aug 19, 2025 at 12:31:14PM +0200, Alvaro Herrera wrote: > Hmm, don't you find strange that dbcommands.h is still included there? > I wondered about that and found out that we have get_database_name() > declared there. It sort-of makes sense, because it was originally done > by scanning pg_database, but since commit cb98e6fb8fd4 introduced a > syscache for it, we can have this routine in lsyscache.c/h instead, > where it feels more at home. It also seems more sensible to declare > get_database_oid() in pg_database.h. After these two changes, a lot of > files can stop including dbcommands.h. This seems a nice cleanup to me, > and passes headerscheck. > > 33 files changed, 39 insertions(+), 56 deletions(-)
Indeed, that's a nice located cleanup. -- Michael
signature.asc
Description: PGP signature
