Fix two errors in extraction of GIN indexquals from jsonpath queries. extract_jsp_bool_expr applied De Morgan's laws incorrectly when considering an AND operator underneath a NOT. If one AND input was implementable as a GIN indexqual while the other was not, we derived an incomplete indexqual, leading to some rows not being returned that should be.
extract_jsp_bool_expr also failed to check for methods being applied to literals, so that for example '$.x == "42".double()' was treated as '$.x == "42"' not '$.x == 42'. The indexqual thus selected the wrong rows, all of which would fail qual recheck, leading to no rows being returned. While we're here, improve the comments a trifle. Reported-by: Chinmay Kanchi <[email protected]> Author: Tom Lane <[email protected]> Discussion: https://postgr.es/m/CAJqPDh9Cm=x8eYZ1Jf=_avd2WEqc=0t_f7_so4igo-ckpi2...@mail.gmail.com Discussion: https://postgr.es/m/cajqpdh-tu5ky66ku8cvaeg3dqrzlzdzwjklla42zd+_xm1w...@mail.gmail.com Backpatch-through: 14 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c138ab8a9bc475b3561cbf574b6c2babcdef7d56 Modified Files -------------- src/backend/utils/adt/jsonb_gin.c | 28 ++++++++++++++++++++++------ src/test/regress/expected/jsonb.out | 30 ++++++++++++++++++++++++++++++ src/test/regress/sql/jsonb.sql | 5 +++++ 3 files changed, 57 insertions(+), 6 deletions(-)
