On 03/21/2014 10:58 PM, Tom Lane wrote:
I wrote:
I think the whole thing is too cute by half.  Why isn't it just

typedef enum GinLogicValue
{
     GIN_FALSE = 0,           /* item is present / matches */
     GIN_TRUE = 1,            /* item is not present / does not match */
     GIN_MAYBE = 2            /* don't know if item is present / don't know if
                               * matches */
} GinLogicValue;

... and now that I look at it a second time: *please* tell me the comments
on the first two values should be swapped.  The API isn't really "false
means a match", is it?

*facepalm*. Yes, the comments are backwards...

- Heikki


--
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Reply via email to