On Mon, May 5, 2014 at 01:08:32PM +0000, Heikki Linnakangas wrote: > Replace SYSTEMQUOTEs with Windows-specific wrapper functions. > > It's easy to forget using SYSTEMQUOTEs when constructing command strings > for system() or popen(). Even if we fix all the places missing it now, it is > bound to be forgotten again in the future. Introduce wrapper functions that > do the the extra quoting for you, and get rid of SYSTEMQUOTEs in all the > callers. > > We previosly used SYSTEMQUOTEs in all the hard-coded command strings, and > this doesn't change the behavior of those. But user-supplied commands, like > archive_command, restore_command, COPY TO/FROM PROGRAM calls, as well as > pgbench's \shell, will now gain an extra pair of quotes. That is desirable, > but if you have existing scripts or config files that include an extra > pair of quotes, those might need to be adjusted.
Should this be mentioned as an incompatibility in the 9.4 release notes? -- Bruce Momjian <[email protected]> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. + -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
