On Tue, May 13, 2014 at 08:19:22AM +0900, Michael Paquier wrote:
> On Tue, May 13, 2014 at 8:18 AM, Bruce Momjian <[email protected]> wrote:
> > On Mon, May 5, 2014 at 01:08:32PM +0000, Heikki Linnakangas wrote:
> >> Replace SYSTEMQUOTEs with Windows-specific wrapper functions.
> >>
> >> It's easy to forget using SYSTEMQUOTEs when constructing command strings
> >> for system() or popen(). Even if we fix all the places missing it now, it
> >> is
> >> bound to be forgotten again in the future. Introduce wrapper functions that
> >> do the the extra quoting for you, and get rid of SYSTEMQUOTEs in all the
> >> callers.
> >>
> >> We previosly used SYSTEMQUOTEs in all the hard-coded command strings, and
> >> this doesn't change the behavior of those. But user-supplied commands, like
> >> archive_command, restore_command, COPY TO/FROM PROGRAM calls, as well as
> >> pgbench's \shell, will now gain an extra pair of quotes. That is desirable,
> >> but if you have existing scripts or config files that include an extra
> >> pair of quotes, those might need to be adjusted.
> >
> > Should this be mentioned as an incompatibility in the 9.4 release notes?
> Definitely worth mentioning.
Done with the attached applied patch.
--
Bruce Momjian <[email protected]> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
diff --git a/doc/src/sgml/release-9.4.sgml b/doc/src/sgml/release-9.4.sgml
new file mode 100644
index cddd66c..abf361a
*** a/doc/src/sgml/release-9.4.sgml
--- b/doc/src/sgml/release-9.4.sgml
***************
*** 203,208 ****
--- 203,223 ----
<listitem>
<para>
+ On Windows, automatically preserve quotes in command strings supplied
+ by the user (Heikki Linnakangas)
+ </para>
+
+ <para>
+ User commands that did their own quote preservation might need
+ adjustment, e.g. <link
+ linkend="guc-archive-command">archive_command</link>, <link
+ linkend="restore-command">restore_command</link>, <command>COPY TO/FROM
+ PROGRAM</>.
+ </para>
+ </listitem>
+
+ <listitem>
+ <para>
Remove system column <link
linkend="catalog-pg-class"><structfield>pg_class.reltoastidxid</></link>
(Michael Paquier)
--
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
