On Tue, Dec 2, 2014 at 4:13 AM, Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > Move security_label test > > Rather than have the core security_label regression test depend on the > dummy_seclabel module, have that part of the test be executed by > dummy_seclabel itself directly. This simplifies the testing rig a bit; > in particular it should silence the problems from the MSVC buildfarm > phylum, which haven't yet gotten taught how to install src/test/modules. After this module has been moved to src/test/modules, I am seeing failures with make check when manually kicking the test on at least OSX where I tried because expected/ and sql/ are missing. pg_regress does not like that much. That's annoying because check-world would simply fail. Also, I think that src/test/modules/dummy_seclabel/Makefile should be taught to clean sql/dummy_seclabel.sql and expected/dummy_seclabel.out with EXTRA_CLEAN and that we should have a .gitignore to ignore tmp_check/ results/ and log/ in this path. Per se the patch attached with those things added. Thanks, -- Michael
diff --git a/src/test/modules/dummy_seclabel/.gitignore b/src/test/modules/dummy_seclabel/.gitignore new file mode 100644 index 0000000..5dcb3ff --- /dev/null +++ b/src/test/modules/dummy_seclabel/.gitignore @@ -0,0 +1,4 @@ +# Generated subdirectories +/log/ +/results/ +/tmp_check/ diff --git a/src/test/modules/dummy_seclabel/Makefile b/src/test/modules/dummy_seclabel/Makefile index 41f50cc..bddfa15 100644 --- a/src/test/modules/dummy_seclabel/Makefile +++ b/src/test/modules/dummy_seclabel/Makefile @@ -4,6 +4,7 @@ MODULES = dummy_seclabel PGFILEDESC = "dummy_seclabel - regression testing of the SECURITY LABEL statement" REGRESS = dummy_seclabel +EXTRA_CLEAN = sql/dummy_seclabel.sql expected/dummy_seclabel.out ifdef USE_PGXS PG_CONFIG = pg_config diff --git a/src/test/modules/dummy_seclabel/expected/.gitignore b/src/test/modules/dummy_seclabel/expected/.gitignore new file mode 100644 index 0000000..2dd2462 --- /dev/null +++ b/src/test/modules/dummy_seclabel/expected/.gitignore @@ -0,0 +1 @@ +/dummy_seclabel.out diff --git a/src/test/modules/dummy_seclabel/sql/.gitignore b/src/test/modules/dummy_seclabel/sql/.gitignore new file mode 100644 index 0000000..ec54e63 --- /dev/null +++ b/src/test/modules/dummy_seclabel/sql/.gitignore @@ -0,0 +1 @@ +/dummy_seclabel.sql
-- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
