Peter Eisentraut wrote: > On 12/2/14 9:18 AM, Alvaro Herrera wrote: > >> After this module has been moved to src/test/modules, I am seeing > >> > failures with make check when manually kicking the test on at least > >> > OSX where I tried because expected/ and sql/ are missing. pg_regress > >> > does not like that much. That's annoying because check-world would > >> > simply fail. > > I had the directories locally but hadn't git-pushed them. > > make check-world still fails.
Ah, it needs errcodes.h to be generated. We can add this (or similar) to the makefiles: OBJS: | submake-errcodes submake-errcodes: $(MAKE) -C $(top_builddir)/src/backend submake-errcodes but it would be very repetitive to have it in all test modules' makefiles. Why doesn't contrib need this? Do you have a better idea? -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers