On Mon, Mar 2, 2015 at 2:38 PM, Tom Lane <[email protected]> wrote: > Robert Haas <[email protected]> writes: >> pgbench: Add a real expression syntax to \set > > The makefile changes in this do not look right to me. Files that are > meant to be shipped in the tarball should be removed by make > maintainer-clean, not an ordinary "make clean" which is what the committed > patch appears to do. Otherwise, a tarball user without bison installed > would be cut off at the knees if he did "make clean" or "make distclean"; > but those operations are not supposed to remove files that were in the > tarball.
Hmm, yeah. Also, it appears that the exprscan.h file doesn't actually get (or need to be) generated here. So I think we need something like the attached. Thought? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgbench-expr-build-fix.patch
Description: binary/octet-stream
-- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
