On Mon, Jan 30, 2023 at 04:17:14PM -0500, Bruce Momjian wrote:
> On Mon, Jan 30, 2023 at 04:07:46PM -0500, Tom Lane wrote:
> > Bruce Momjian <[email protected]> writes:
> > > On Thu, Jan 26, 2023 at 12:19:29PM +0000, PG Doc comments form wrote:
> > >> From time to time some spelling for given command gets obsolete, yet it
> > >> is
> > >> shown in the syntax on "equal rights" as other valid clauses.
> >
> > > We don't need to show all _supported_ syntaxes in the "Synopsis"
> > > section, so we could just remove them.
> >
> > IIRC, there is precedent in COPY for moving obsolete alternatives
> > to a separate part of the man page. I'd prefer that to just
> > removing them, because then there is no documentation to help
> > someone understand what an old SQL script is doing.
>
> Yeah, I remember that with COPY. [email protected], please us that
> as a guide. Thanks.
I developed the attached patch to move the deprecated clauses to the
bottom.
--
Bruce Momjian <[email protected]> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
diff --git a/doc/src/sgml/ref/create_role.sgml b/doc/src/sgml/ref/create_role.sgml
index 7249fc7432..6a3cd6d808 100644
--- a/doc/src/sgml/ref/create_role.sgml
+++ b/doc/src/sgml/ref/create_role.sgml
@@ -36,10 +36,8 @@ CREATE ROLE <replaceable class="parameter">name</replaceable> [ [ WITH ] <replac
| [ ENCRYPTED ] PASSWORD '<replaceable class="parameter">password</replaceable>' | PASSWORD NULL
| VALID UNTIL '<replaceable class="parameter">timestamp</replaceable>'
| IN ROLE <replaceable class="parameter">role_name</replaceable> [, ...]
- | IN GROUP <replaceable class="parameter">role_name</replaceable> [, ...]
| ROLE <replaceable class="parameter">role_name</replaceable> [, ...]
| ADMIN <replaceable class="parameter">role_name</replaceable> [, ...]
- | USER <replaceable class="parameter">role_name</replaceable> [, ...]
| SYSID <replaceable class="parameter">uid</replaceable>
</synopsis>
</refsynopsisdiv>
@@ -294,15 +292,6 @@ in sync when changing the above synopsis!
</listitem>
</varlistentry>
- <varlistentry>
- <term><literal>IN GROUP</literal> <replaceable class="parameter">role_name</replaceable></term>
- <listitem>
- <para><literal>IN GROUP</literal> is an obsolete spelling of
- <literal>IN ROLE</literal>.
- </para>
- </listitem>
- </varlistentry>
-
<varlistentry>
<term><literal>ROLE</literal> <replaceable class="parameter">role_name</replaceable></term>
<listitem>
@@ -326,16 +315,6 @@ in sync when changing the above synopsis!
</listitem>
</varlistentry>
- <varlistentry>
- <term><literal>USER</literal> <replaceable class="parameter">role_name</replaceable></term>
- <listitem>
- <para>
- The <literal>USER</literal> clause is an obsolete spelling of
- the <literal>ROLE</literal> clause.
- </para>
- </listitem>
- </varlistentry>
-
<varlistentry>
<term><literal>SYSID</literal> <replaceable class="parameter">uid</replaceable></term>
<listitem>
@@ -484,6 +463,22 @@ CREATE ROLE <replaceable class="parameter">name</replaceable> [ WITH ADMIN <repl
by giving users the <literal>NOINHERIT</literal> attribute, while roles are
given the <literal>INHERIT</literal> attribute.
</para>
+
+ <para>
+ The <literal>USER</literal> clause has the same behavior as
+ <literal>ROLE</literal> but has been deprecated:
+<synopsis>
+ USER <replaceable class="parameter">role_name</replaceable> [, ...]
+</synopsis>
+ </para>
+
+ <para>
+ The <literal>IN GROUP</literal> clause has the same behavior as <literal>IN
+ ROLE</literal> but has been deprecated:
+<synopsis>
+ IN GROUP <replaceable class="parameter">role_name</replaceable> [, ...]
+</synopsis>
+ </para>
</refsect1>
<refsect1>
