Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <[email protected]> writes:
> > > Tom Lane wrote:
> > >> You know, it suddenly strikes me that this is going in largely the wrong
> > >> direction.
> > 
> > > Right, the problem particularly is with the -1/special values that don't
> > > have a real unit.
> > 
> > I don't object to what you did to postgresql.conf.sample, but I think
> > you should revert the changes to the descriptions in guc.c.
> 
> Agreed;  attached patch applied.

However, keep in mind that units are _not_ displayed for zero values:

        test=> show statement_timeout;
         statement_timeout
        -------------------
         0
        (1 row)
        
        test=> set statement_timeout = 100;
        SET
        test=> show statement_timeout;
         statement_timeout
        -------------------
         100ms
        (1 row)

because of this test in guc.c:

                    else if (use_units && result > 0 &&
                             (record->flags & GUC_UNIT_TIME))

pg_settings does show the units.  Changing this to display the units
might be odd since many zero values mean 'disabled'.

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

Reply via email to