On Fri, Apr 17, 2026 at 10:47 AM Euler Taveira <[email protected]> wrote: > On Thu, Apr 16, 2026, at 8:46 PM, Amit Langote wrote: > > > > Thanks. Will push the attached shortly. > > I think the errhint() is excessive in this context. It makes sense if you are > executing ALTER DATABASE, for example.
Yeah, agreed. > I suggest a message like > > database \"%s\" is an invalid database Or just drop it, because the errmsg already says "invalid database %s". > Regarding the test case suggested by Japin Li, I don't think it is worth > because > it is a transient state (unless something bad happened and pg_database > contains > a dangling row.) Agreed. Patch updated. -- Thanks, Amit Langote
v3-0001-Reject-invalid-databases-in-pg_get_database_ddl.patch
Description: Binary data
