On Tue, Oct 13, 2026 at 3:07 AM surya poondla <[email protected]> wrote: > The patch looks ready for a Committer.
DecodeXLogRecord() changes in 0001 patch look good to me. But, do we really need a new test for such a small fix? Generating and locating a record, handling boundaries, modifying WAL, recomputing the CRC, and copying the segment seem like a lot of complexity and maintenance overhead just to verify the reported LSN, I'm afraid. If we really want this, seems it's better to consider it separately as a test for malformed WAL detection, including the LSN check. I'm just not sure this additional infrastructure is worth the effort, though.. Regards, -- Fujii Masao
