On Sat, Oct 31, 2026 at 12:52 AM surya poondla <[email protected]> wrote: > Also, what do you think about 0002? It makes pg_waldump's "error in WAL > record at" prefix show where reading failed, instead of the last > good record.
EndRecPtr is the starting position for the next read, which does not always correspond to the start of the failing record. No? For example, if decoding fails on the first record after a page header, EndRecPtr still points to the start of the page? So if the goal is to report the exact location of the failing record, isn't this change insufficient? OTOH, if the goal is consistency with pg_rewind and pg_walinspect, I'm fine with using EndRecPtr. But, as with 0001, I don't think the test change in 0002 is necessary. Regards, -- Fujii Masao
