On Sun, Nov 19, 2017 at 7:49 PM, Badrul Chowdhury <bac...@microsoft.com> wrote: >>> I spent a little more time looking at this patch today. I think that the >>> patch >>> should actually send NegotiateProtocolVersion when *either* the requested >>> version is differs from the latest one we support *or* an unsupported >>> protocol >>> option is present. Otherwise, you only find out about unsupported protocol >>> options if you also request a newer minor version, which isn't good, >>> because it >>> makes it hard to add new protocol options *without* bumping the protocol >>> version. > > It makes sense from a maintainability point of view. > >>> Here's an updated version with that change and a proposed commit message. > > I have tested the new patch and it works great. The comments look good as > well.
Committed and back-patched to all supported branches. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
