On Fri, Jan 12, 2018 at 12:43:22AM +1300, Thomas Munro wrote: > Yeah, I think you're right. That's an oversight in 18ce3a4a.
+1. > I'm surprised we haven't heard any complaints sooner if there are > advisors using that hook[1] and expecting to be able to forward to > ExplainOnePlan(), but I suppose it would nearly always works to call > ExplainOnePlan() with NULL as queryEnv. It'd currently only be > non-NULL for trigger functions running SQL to access transition > tables, which is a bit obscure: you'd need to run EXPLAIN inside a > suitable trigger function (though in future there might be more ways > to create named tuplestore relations). It seems to me that QueryEnv should be pushed to the hook, but only on HEAD. You surely don't want to break people's extensions after a minor upgrade. -- Michael
signature.asc
Description: PGP signature
