Hello. Thanks a lot for review.
Patch updated + rebased on master. check-world is passing. Still not sure about comment formatting. Have you seen any style guid about it except "strict ANSI C comment formatting"? Anyway still need to work on comments. Also, non-MVCC snaphots are now supported. Github is updated too. https://github.com/postgres/postgres/compare/master...michail-nikolaev:offset_index_only Still not sure about questions 0, 2, 3, 4, 5, and 6 from initial mail (about explain, explain analyze, documentation and optimiser). Thanks. пн, 5 февр. 2018 г. в 23:36, Andrey Borodin <x4...@yandex-team.ru>: > Hi, Michail! > > Thanks for the patch! > > > 1 февр. 2018 г., в 1:17, Michail Nikolaev <michail.nikol...@gmail.com> > написал(а): > > > > Hello. > > > > WIP-Patch for optimisation of OFFSET + IndexScan using visibility map. > > While the patch seems to me useful improvement, I see few problems with > code: > 1. Both branches of "if (node->iss_tuples_skipped_remaning != 0)" seem too > similar. There is a lot of duplicate comments et c. I think that this > branch should be refactored to avoid code duplication. > 2. Most of comments are formatted not per project style. > > Besides this, patch looks good. Please, add it to the following commitfest > so that work on the patch could be tracked. > > Best regards, Andrey Borodin.
Description: Binary data