On Mon, Mar 05, 2018 at 05:06:59PM -0800, Andres Freund wrote: > Yea, that's a concern. OTOH, it doesn't seem nice to grow duplicates of > similar code. It'd not be too hard to move RangeVarGetRelidExtended() > code into RangeVarGetRelidInternal() and add > RangeVarGetRelidTryLock(). Not sure if that's any better. Or just add > RangeVarGetRelidExtended2() :)
FWIW, it would have been nice to switch RangeVarGetRelidExtended so as it handles a set of uint8 flags as one of its arguments. missing_ok and nowait could be part of that. Avoiding a new flavor of RangevarGet would be also nice, now RangeVarGetRelidExtended() is likely popular enough in extensions that much things would break. -- Michael
signature.asc
Description: PGP signature
