Hello, I reviewed your patch. At a first glance, I have the below comments.
1. The below change crosses the 80-character limit in a line. Please maintain the same. - "LARGE OBJECT", "TABLESPACE", "TEXT SEARCH", "ROLE"); + "LARGE OBJECT", "TABLESPACE", "TEXT SEARCH", "TRANSFORM FOR", "ROLE"); 2. There are trailing whitespaces after COMPLETE_WITH_QUERY(Query_for_list_of_languages);. Remove these extra whitespaces. surajkhamkar@localhost:tab_comment$ git apply fix_tab_complete_comment.patch fix_tab_complete_comment.patch:38: trailing whitespace. COMPLETE_WITH_QUERY(Query_for_list_of_languages); warning: 1 line adds whitespace errors. Regards, Suraj Khamkar On Wed, Sep 29, 2021 at 2:04 PM katouknl <katou...@oss.nttdata.com> wrote: > Hi, > > I created a patch for COMMENT tab completion. > It was missing TRANSFORM FOR where it's supposed to be. > > Best wishes, > Ken Kato
