Hello,
Thanks for the revised patch.
It is very good, but it seems to me that there are some tab-completion
> missing in COMMENT command.
Thanks Shinya, for having a look. I was also about to say that it would be
good
if we take care of tab-completion for other options as well in this patch
itself.
I would like to ask @katouknl <katou...@oss.nttdata.com> if it's ok to do
so.
And regarding the revised patch, arranging options in alphabetical order
seems
good to me. Though, there is one line where it crosses 80 characters in a
line.
+ COMPLETE_WITH("ACCESS METHOD", "AGGREGATE", "CAST", "COLLATION", "COLUMN",
Apart from this I don't have any major comment.
Regards,
Suraj Khamkar
On Thu, Oct 7, 2021 at 3:29 PM Shinya Kato <shinya11.k...@oss.nttdata.com>
wrote:
> On 2021-10-07 17:14, katouknl wrote:
> > Hi,
> >
> > Thank you for the review.
> >
> > I wasn't quite sure where to start counting the characters,
> > but I used pgindent to properly format it, so hopefully everything is
> > okay.
> > Also, I sorted them in alphabetical order just to make it look
> > prettier.
> >> * The below change crosses the 80-character limit in a line. Please
> >> maintain the same.
> >> - "LARGE OBJECT", "TABLESPACE", "TEXT SEARCH", "ROLE");
> >> + "LARGE OBJECT", "TABLESPACE", "TEXT SEARCH", "TRANSFORM FOR",
> >> "ROLE");
> >
> > I made sure there is no whitespaces this time.
> >> * There are trailing whitespaces after
> >> COMPLETE_WITH_QUERY(Query_for_list_of_languages);.
> >> Remove these extra whitespaces.
> >> surajkhamkar@localhost:tab_comment$ git apply
> >> fix_tab_complete_comment.patch
> >> fix_tab_complete_comment.patch:38: trailing whitespace.
> >> COMPLETE_WITH_QUERY(Query_for_list_of_languages);
> >> warning: 1 line adds whitespace errors.
> Thank you for the patch!
> It is very good, but it seems to me that there are some tab-completion
> missing in COMMENT command.
> For example,
> - CONSTRAINT ... ON DOMAIN
> - OPERATOR CLASS
> - OPERATOR FAMILY
> - POLICY ... ON
> - [PROCEDURAL]
> - RULE ... ON
> - TRIGGER ... ON
>
> I think these tab-comletion also can be improved and it's a good timing
> for that.
>
> --
> Regards,
>
> --
> Shinya Kato
> Advanced Computing Technology Center
> Research and Development Headquarters
> NTT DATA CORPORATION
>
