On Friday, October 29, 2021 12:35 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Thu, Oct 28, 2021 at 9:55 AM vignesh C <vignes...@gmail.com> wrote: > > > > Thanks for committing the patch, please find the remaining patches attached. > > Thanks Hou Zhijie and Greg Nancarrow for sharing a few comments > > offline, I have fixed those in the attached patch. > > > > Pushed the first test case patch. About > v48-0002-Add-new-pg_publication_objects-view-to-display-T, I think it > doesn't display anything for "for all tables" publication. Instead of > selecting from pg_publication_rel, you can use the existing view > pg_publication_tables to solve that problem. > > Having said that, I am not completely sure about the value of this new > view pg_publication_objects which displays all objects of > publications. I see that users might want to see all the objects that > the publication publishes and when we include other objects like > sequences it might be more helpful. > > Sawada-San, others, what do you think? Is it really useful to have such a > view? > > One point to think is if we introduce such a view then how it should > behave for schema objects? Do we need to display only schemas or > additionally all the tables in the schema as well? If you follow the > above suggestion of mine then I think it will display both schemas > published and tables in that schema that will be considered for > publishing. >
Personally, if I want to see ALL the published objects in a publication, I would use '\dRp+' command. I think there might not be too much value to have this view. Regards Tang
