On Mon, Nov 1, 2021 at 2:48 AM Tomas Vondra <tomas.von...@enterprisedb.com> wrote: > > On 10/28/21 04:41, Amit Kapila wrote: > > On Mon, Oct 25, 2021 at 3:09 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > >> > >> On Mon, Oct 25, 2021 at 1:11 PM vignesh C <vignes...@gmail.com> wrote: > >>> > >>> I have fixed this in the v47 version attached. > >>> > >> > >> Thanks, the first patch in the series "Allow publishing the tables of > >> schema." looks good to me. Unless there are more > >> comments/bugs/objections, I am planning to commit it in a day or so. > >> > > > > Yesterday, I have pushed the first patch. Feel free to submit the > > remaining patches. > > > > I haven't been following this thread recently, but while rebasing the > sequence decoding patch I noticed this adds > > PUBLICATIONOBJ_TABLE, /* Table type */ > PUBLICATIONOBJ_REL_IN_SCHEMA, /* Relations in schema type */ > > Shouldn't it be PUBLICATIONOBJ_TABLE_IN_SCHEMA, or why does it use rel > instead of table? >
Yeah, it should be PUBLICATIONOBJ_TABLE_IN_SCHEMA considering we have to add other objects like sequence. > I'm asking because the sequence decoding patch mimics ALTER PUBLICATION > options for sequences, including ALL SEQUENCES IN SCHEMA etc. and this > seems ambiguous. The same issue applies to PUBLICATIONOBJ_CURRSCHEMA, > which does not specify the object type. > I think we should name it PUBLICATIONOBJ_TABLE_CURRSCHEMA. Does that make sense? > I wonder if it'd be better to just separate the schema and object type > specification, instead of mashing it into a single constant. > Do you mean to say the syntax on the lines of Create Publication For Table t1, t2 Schema s1, s2;? If so, then originally the patch had the syntax on those lines but Tom pointed out that the meaning of such a syntax can change over a period of time and that can break apps [1]. I think the current syntax gives a lot of flexibility to users and we have some precedent for it as well. [1] - https://www.postgresql.org/message-id/155565.1628954580%40sss.pgh.pa.us -- With Regards, Amit Kapila.
