On Wed, Nov 3, 2021 12:25 PM vignesh C <vignes...@gmail.com> wrote: > On Wed, Nov 3, 2021 at 8:30 AM Amit Kapila <amit.kapil...@gmail.com> > wrote: > > > > On Tue, Nov 2, 2021 at 8:13 PM Tomas Vondra > > <tomas.von...@enterprisedb.com> wrote: > > > > > > > > > > > > > > Yeah, that is also true. So maybe at this, we can just rename the > > > > few types as suggested by you and we can look at it later if we > > > > anytime have more number of objects to add. > > > > > > > > > > +1 > > > > > > > Apart from what you have pointed above, we are using > > "DO_PUBLICATION_REL_IN_SCHEMA" in pg_dump. I think we should replace > > that as well with "DO_PUBLICATION_TABLE_IN_SCHEMA". > > Thanks for the comments, the attached patch has the changes for the same. >
Thanks for the patch. I have only one minor comment: + PUBLICATIONOBJ_TABLE_IN_SCHEMA, /* Relations in schema type */ I think the ' Relations' in the comments also need to be changed to 'tables'. The other part of the patch looks good to me. Best regards, Hou zj
