On Mon, Nov 15, 2021 at 12:13 PM vignesh C <vignes...@gmail.com> wrote: > > On Mon, Nov 15, 2021 at 11:00 AM Bharath Rupireddy > <bharath.rupireddyforpostg...@gmail.com> wrote: > > > > On Mon, Nov 15, 2021 at 10:34 AM vignesh C <vignes...@gmail.com> wrote: > > > > 2) I think "which is enough because the target process for logging of > > > > backtrace is a backend" isn't valid anymore with 0002, righit? Please > > > > remove it. > > > > + * to call this function if we see PrintBacktracePending set. It is > > > > called from > > > > + * CHECK_FOR_INTERRUPTS() or from process specific interrupt handlers, > > > > which is > > > > + * enough because the target process for logging of backtrace is a > > > > backend. > > > > > > > > > Thanks for the comments, v11 patch attached at [1] has the changes > > > > > for the same. > > > > > > Modified > > > > I don't see the above change in v12. Am I missing something? I still > > see the comment "It is called from CHECK_FOR_INTERRUPTS(), which is > > enough because the target process for logging of backtrace is a > > backend.". > > This change is present in the 0002 > (v12-0002-pg_print_backtrace-support-for-printing-backtrac.patch) > patch.
Thanks. Yes, it was removed in 0002. I missed it. Regards, Bharath Rupireddy.