In dir_open_for_write() I observe that we are writing the header and then calling LZ4F_compressEnd() in case there is an error while writing the buffer to the file, and the output buffer of LZ4F_compressEnd() is not written anywhere. Why should this be necessary? To flush the contents of the internal buffer? But, then we are calling LZ4F_freeCompressionContext() immediately after the LZ4F_compressEnd() call. I might be missing something, will be happy to get more insights.
Regards, Jeevan Ladhe On Fri, Nov 5, 2021 at 1:21 PM <gkokola...@pm.me> wrote: > > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > > On Friday, November 5th, 2021 at 3:47 AM, Michael Paquier < > mich...@paquier.xyz> wrote: > > > > > I have spent an extra couple of hours staring at the code, and the > > whole looked fine, so applied. While on it, I have tested the new TAP > > tests with all the possible combinations of --without-zlib and > > --with-lz4. > > Great news. Thank you very much. > > Cheers, > //Georgios > > > -- > > Michael > > >
