On Mon, Nov 22, 2021 at 12:46 AM Jeevan Ladhe <jeevan.la...@enterprisedb.com> wrote: > Fair enough. But, still I have a doubt in mind what benefit would that > really bring to us here, because we are immediately also freeing the > lz4buf without using it anywhere.
Yeah, I'm also doubtful about that. If we're freeng the compression context, we shouldn't need to guarantee that it's in any particular state before doing so. Why would any critical cleanup be part of LZ4F_compressEnd() rather than LZ4F_freeCompressionContext()? The point of LZ4F_compressEnd() is to make sure all of the output bytes get written, and it would be stupid to force people to write the output bytes even when they've decided that they no longer care about them due to some error. -- Robert Haas EDB: http://www.enterprisedb.com
