On Wed, Jan 12, 2022 at 7:08 PM Zhihong Yu <z...@yugabyte.com> wrote:
> > > On Wed, Jan 12, 2022 at 6:49 PM Noah Misch <n...@leadboat.com> wrote: > >> On Mon, Jan 10, 2022 at 03:34:27PM -0800, Zhihong Yu wrote: >> > On Sun, Jan 9, 2022 at 6:45 PM Zhihong Yu <z...@yugabyte.com> wrote: >> > > gcc -Wall -Wmissing-prototypes -Wpointer-arith >> > > -Wdeclaration-after-statement -Werror=vla -Wendif-labels >> > > -Wmissing-format-attribute -Wimplicit-fallthrough=3 >> -Wcast-function-type >> > > -Wformat-security -fno-strict-aliasing -fwrapv >> -fexcess-precision=standard >> > > -Wno-format-truncation -Wno-stringop-truncation -fsanitize=undefined >> > > -fsanitize-undefined-trap-on-error -I../../src/port -DFRONTEND >> > > -I../../src/include -D_GNU_SOURCE -c -o path.o path.c >> > >> > Patch v3 passes `make check-world` >> >> The patch uses the "LENGTH_VAR != 0" style in px.c, but it uses >> "POINTER_VAR >> != NULL" style in the other files. Please use "LENGTH_VAR != 0" style in >> each >> place you're changing. >> >> Assuming the next version looks good, I'll likely back-patch it to v10. >> Would >> anyone like to argue for a back-patch all the way to 9.2? >> > Hi, > Please take a look at patch v5. > > Cheers > Noah: Do you have any more review comments ? Thanks
