On Fri, Feb 4, 2022 at 2:58 PM houzj.f...@fujitsu.com <houzj.f...@fujitsu.com> wrote: > > On Thursday, February 3, 2022 11:11 PM houzj.f...@fujitsu.com > <houzj.f...@fujitsu.com> > > Since the v76-0000-clean-up-pgoutput-cache-invalidation.patch has been > committed, attach a new version patch set to make the cfbot happy. Also > addressed the above comments related to tab-complete in 0002 patch. >
I don't like some of the error message changes in this new version. For example: v75: +CREATE FUNCTION testpub_rf_func1(integer, integer) RETURNS boolean AS $$ SELECT hashint4($1) > $2 $$ LANGUAGE SQL; +CREATE OPERATOR =#> (PROCEDURE = testpub_rf_func1, LEFTARG = integer, RIGHTARG = integer); +CREATE PUBLICATION testpub6 FOR TABLE testpub_rf_tbl3 WHERE (e =#> 27); +ERROR: invalid publication WHERE expression for relation "testpub_rf_tbl3" +DETAIL: User-defined operators are not allowed. v77 +CREATE FUNCTION testpub_rf_func1(integer, integer) RETURNS boolean AS $$ SELECT hashint4($1) > $2 $$ LANGUAGE SQL; +CREATE OPERATOR =#> (PROCEDURE = testpub_rf_func1, LEFTARG = integer, RIGHTARG = integer); +CREATE PUBLICATION testpub6 FOR TABLE testpub_rf_tbl3 WHERE (e =#> 27); +ERROR: invalid publication WHERE expression +LINE 1: ...ICATION testpub6 FOR TABLE testpub_rf_tbl3 WHERE (e =#> 27); + ^ +DETAIL: User-defined or mutable functions are not allowed I think the detailed message by v75 "DETAIL: User-defined operators are not allowed." will be easier for users to understand. I have made some code changes and refactoring to make this behavior like previous without removing the additional checks you have added in v77. I have made a few changes to comments and error messages. Attached is a top-up patch on your v77 patch series. I suggest we can combine the 0001 and 0002 patches as well. -- With Regards, Amit Kapila.
v77_diff_amit.1.patch
Description: Binary data
