Hi, Thank you for developing of the great feature. If multiple tables are specified when creating a PUBLICATION, is it supposed that the WHERE clause condition is given to only one table? I attached the operation log below.
--- operation log --- postgres=> CREATE TABLE data1(c1 INT PRIMARY KEY, c2 VARCHAR(10)); CREATE TABLE postgres=> CREATE TABLE data2(c1 INT PRIMARY KEY, c2 VARCHAR(10)); CREATE TABLE postgres=> CREATE PUBLICATION pub1 FOR TABLE data1,data2 WHERE (c1 < 1000); CREATE PUBLICATION postgres=> \d data1 Table "public.data1" Column | Type | Collation | Nullable | Default --------+-----------------------+-----------+----------+--------- c1 | integer | | not null | c2 | character varying(10) | | | Indexes: "data1_pkey" PRIMARY KEY, btree (c1) Publications: "pub1" postgres=> \d data2 Table "public.data2" Column | Type | Collation | Nullable | Default --------+-----------------------+-----------+----------+--------- c1 | integer | | not null | c2 | character varying(10) | | | Indexes: "data2_pkey" PRIMARY KEY, btree (c1) Publications: "pub1" WHERE (c1 < 1000) postgres=> SELECT prrelid, prqual FROM pg_publication_rel; prrelid | prqual ---------+----------------------------------------------------------------------------- 16408 | 16413 | {OPEXPR :opno 97 :opfuncid 66 :opresulttype 16 :opretset false :opcol lid 0 :inputcollid 0 :args ({VAR :varno 1 :varattno 1 :vartype 23 :vartypmod -1 :varcollid 0 :varlevelsup 0 :varnosyn 1 :varattnosyn 1 :location 53} {CONST :con sttype 23 :consttypmod -1 :constcollid 0 :constlen 4 :constbyval true :constisnu ll false :location 58 :constvalue 4 [ -24 3 0 0 0 0 0 0 ]}) :location 56} (2 rows) Regards, Noriyoshi Shinoda -----Original Message----- From: Amit Kapila <amit.kapil...@gmail.com> Sent: Wednesday, February 23, 2022 11:06 AM To: Euler Taveira <eu...@eulerto.com> Cc: houzj.f...@fujitsu.com; Peter Smith <smithpb2...@gmail.com>; Alvaro Herrera <alvhe...@alvh.no-ip.org>; Greg Nancarrow <gregn4...@gmail.com>; vignesh C <vignes...@gmail.com>; Ajin Cherian <itsa...@gmail.com>; tanghy.f...@fujitsu.com; Dilip Kumar <dilipbal...@gmail.com>; Rahila Syed <rahilasye...@gmail.com>; Peter Eisentraut <peter.eisentr...@enterprisedb.com>; Önder Kalacı <onderkal...@gmail.com>; japin <japi...@hotmail.com>; Michael Paquier <mich...@paquier.xyz>; David Steele <da...@pgmasters.net>; Craig Ringer <cr...@2ndquadrant.com>; Amit Langote <amitlangot...@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org> Subject: Re: row filtering for logical replication On Tue, Feb 22, 2022 at 4:47 AM Euler Taveira <eu...@eulerto.com> wrote: > > On Thu, Feb 17, 2022, at 3:36 AM, Amit Kapila wrote: > > As there is a new version, I would like to wait for a few more days > before committing. I am planning to commit this early next week (by > Tuesday) unless others or I see any more things that can be improved. > > Amit, I don't have additional comments or suggestions. Let's move on. > Next topic. :-) > Pushed! -- With Regards, Amit Kapila.