Thanks to everyone, fixes are pushed except nodeMerge.c, I don't wish to increase entropy around MERGE patch :)

Kyotaro HORIGUCHI wrote:
Hello.

The commit leaves three warnings for
-Wunused-but-set-variable. Two of them are not assertion-only but
really not used at all.

I also found that nodeMerge.c has one such variable.

regards.

At Thu, 5 Apr 2018 15:43:55 +0900, Masahiko Sawada <sawada.m...@gmail.com> wrote in 
<CAD21AoAtYzXeuhPqGw89KxqcJWpSKxWRNkYzyJxAqJHZham==q...@mail.gmail.com>
On Thu, Apr 5, 2018 at 2:40 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote:
On Thu, Apr 5, 2018 at 1:30 AM, Teodor Sigaev <teo...@sigaev.ru> wrote:
Thanks for everyone, pushed with minor editorization


Thank you for committing!
I found a typo in nbtpage.c and attached a patch fixes it.


I also found an incorrect documentation in create_index.sgml as follows.

      <term><literal>vacuum_cleanup_index_scale_factor</literal></term>
      <listitem>
      <para>
       Per-table value for <xref
linkend="guc-vacuum-cleanup-index-scale-factor"/>.
      </para>
      </listitem>
     </varlistentry>

I think it should be "Per-index". Attached a patch for fixing it. And
sorry for missing it at review.

Regards,


--
Teodor Sigaev                                   E-mail: teo...@sigaev.ru
                                                   WWW: http://www.sigaev.ru/

Reply via email to